Write arbitrary instance for data that uses sized #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdvisscher
approved these changes
Dec 8, 2021
|
@Yasuke Looks good; I think it would also make sense to have a few tests that confirm this is working how you'd expect? |
By using sized we can have an arbitrary instance that actually terminates and is configurable via standard QuickCheck methods (e.g. generate, resize). This will allow testing with Datums and will prevent users unintentionally stalling their tests when generating Datums, BuiltinData, and Data. Fixes IntersectMBO#172.
Yasuke
force-pushed
the
so/bounded-arbitrary-data
branch
from
1395654
to
a1a5717
Compare
|
Test-suite added and comments addressed. |
Yasuke
force-pushed
the
so/bounded-arbitrary-data
branch
from
e3ebd65
to
1ea9082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using sized we can have an arbitrary instance that actually
terminates and is configurable via standard QuickCheck
methods (e.g. generate, resize). This will allow testing with Datums and
will prevent users unintentionally stalling their tests when generating
Datums, BuiltinData, and Data. Fixes #172.