Add passphrase to ledger signing api

[Yasuke]

This addresses #168; Instead of having the passphrase for signing
hardcoded to "Ledger.Crypto PassPhrase", allow the passphrase to be
provided. This way we aren't prevented from using private keys
created with tools like cardano-address and cardano-cli

[silky]

Looks pretty good @Yasuke , maybe I could suggest a few potential refactorings/additional items:

1. Perhaps introduce a new function, signMessage, signObservation'`, that use the default, and the un-ticked ones take the passphrase. This way we don't have random empty-strings in a few places,
2. Might not hurt to wrap up the PassPhrase in a newtype, so that it's a bit more clear it's purpose (and to allow later for nuanced handling, if we wish it),
3. Maybe we could take this opportunity to have a few tests that verify this behaviour? (Not sure what tests we have already around verifying signatures and passphrases?)

Thanks for the work so far! :)

[volodyad]

Any progress on this?

[volodyad]

Tried to build from PR branch - and it fails
src/Cardano/Wallet/Mock/Handlers.hs:128:23: error:
• Couldn't match expected type ‘Eff effs MockWallet’
with actual type ‘BS.ByteString -> Eff effs0 MockWallet’
• Probable cause: ‘newWallet’ is applied to too few arguments

[szg251]

@silky @Yasuke sorry for urging you, but this issue is a blocker for other work, could we prioritize merging this once it builds?

[silky]

Hi @gege251 ; sorry to hear it is blocking you. As you can see, we are working on it, and it will be merged in due course :)

[Yasuke]

Thank you for the feedback and review @silky! I have make Passphrase a distinct type, added prime functions that don't require a password, added some tests (and instances needed to make them work) for signing in both the ledger and oracle.

[Yasuke]

I also generalized the ledger signing function to work with any ByteArrayAccess instead of just TxIds

[sjoerdvisscher]

Really nice work!

[Yasuke]

Pending CI, required adjustments have been made, thanks @sjoerdvisscher for the review

[Yasuke]

Rebased on current main

[volodyad]

hello, when this PR are planned to be merged?

[sjoerdvisscher]

Thanks for the reminder!