Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raiseMUnderN to freer-extras #175

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented Dec 6, 2021

This may seem silly, but I needed this for M = 6 and N = 3.

The mapEffs function seems generally useful, so I suggested to add it to freer-simple: lexi-lambda/freer-simple#37

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@sjoerdvisscher sjoerdvisscher requested review from j-mueller and michaelpj and removed request for j-mueller December 6, 2021 16:08
Copy link
Contributor

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember any of this, but I trust that you know what you're doing, and if it compiles it's probably fine.

@sjoerdvisscher
Copy link
Contributor Author

@michaelpj Lol, your memory has a healthy bit of garbage collection then!

@sjoerdvisscher sjoerdvisscher merged commit a53bfca into main Dec 7, 2021
@sjoerdvisscher sjoerdvisscher deleted the sv/freer-raiseMUnderN branch December 7, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants