Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store evaluation with its simulation #155

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

sjoerdvisscher
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher commented Nov 30, 2021

Also removed the release banner and renamed Blocks to Slots in the Wait For action.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

where
set (Cursor index xs) a = Cursor index $ fromMaybe xs $ Array.updateAt index a xs

pre c@(Cursor index xs) = maybe (Left c) Right $ Array.index xs index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

, _walletKeys
, _knownCurrencies
, _result
, _warnings
, getKnownCurrencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔠

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vscode plugin apparently sorts the exports if you tell it to add another one.

Copy link
Contributor

@jhbertra jhbertra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@sjoerdvisscher sjoerdvisscher merged commit ad40233 into main Dec 1, 2021
@sjoerdvisscher sjoerdvisscher deleted the SCP-1393-evaluation-per-simulation branch December 1, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants