Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP-3064: Fixed failing test case in the Crowdfunding plutus use case #131

Merged
merged 1 commit into from
Nov 23, 2021
Merged

SCP-3064: Fixed failing test case in the Crowdfunding plutus use case #131

merged 1 commit into from
Nov 23, 2021

Conversation

koslambrou
Copy link
Contributor

The failing test case can be run using:

cabal test plutus-use-cases --test-options="-p \"crowdfunding.QuickCheck ContractModel\" --quickcheck-replay=714845"

This corrects a bug resulting from the PR #76

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@koslambrou koslambrou force-pushed the scp-2880-emulator-txout-min-1ada branch from 3e28797 to f73b848 Compare November 22, 2021 19:33
sjoerdvisscher
sjoerdvisscher approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@koslambrou koslambrou merged commit ee6d1ee into main Nov 23, 2021
@koslambrou koslambrou deleted the scp-2880-emulator-txout-min-1ada branch November 23, 2021 12:02
@koslambrou koslambrou restored the scp-2880-emulator-txout-min-1ada branch November 23, 2021 12:02
@koslambrou koslambrou deleted the scp-2880-emulator-txout-min-1ada branch November 23, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoerdvisscher sjoerdvisscher sjoerdvisscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koslambrou @sjoerdvisscher