WIP mux improvements for 10.2.1 #5077
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower level benchmark for reading and writing over Sockets. Uses local TCP sockets over ephemeral ports.
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
2 times, most recently
from
f5a2cca to
6bba9f0
Compare
karknu
commented
Feb 18, 2025
karknu
commented
Feb 18, 2025
karknu
commented
Feb 18, 2025
karknu
commented
Feb 18, 2025
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
from
2e1b74b to
dd44444
Compare
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
3 times, most recently
from
4d6a898 to
bb34c24
Compare
Enforce at least 1 byte payload data per SDU.
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
from
bb34c24 to
3fe8dbe
Compare
Define msHeaderLength and use it instead of 8 as hardcoded headerlength.
Permit sending of multiple SDUs through a single call to sendMany for Socket bearers Bearers without vector IO support emulate it through multiple calls to write.
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
from
3fe8dbe to
b772d9f
Compare
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
from
b772d9f to
248f449
Compare
This implements an optional read buffer for the Socket bearer. If provided with a read buffer the socket bearer will read as much data available on the socket that can fit in the read buffer. Subsequent read requests will first be served data from the buffer.
Poll the egress queue at most 1000 times per second. This gives us an oppertunity to pack multiple messages into larger SDUs, and write those SDUs with a single sendMany call.
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
from
248f449 to
096f32b
Compare
Use a Builder for ingress. Messages shorter than 128 bytes will be copied.
Use RecvLowWater to signal that we want to read at least the length of the SDU.
karknu
force-pushed
the
karknu/10_2_1_read_buffer
branch
from
096f32b to
a45df26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reasonably detailed description of the pull request
Checklist
Quality
Maintenance
ouroboros-networkproject.