Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: fixed caching #4995

Merged
merged 2 commits into from
Oct 21, 2024
Merged

github-actions: fixed caching #4995

merged 2 commits into from
Oct 21, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 21, 2024

Fixed caching of cabal store: https://github.com/IntersectMBO/ouroboros-network/actions/runs/11435190378/job/31810104749

  • more robust way of cache key management
  • removed enableCrossArchive (it doesn't seem to be necessary now)
  • only save the cache when necessary

@coot coot force-pushed the coot/gha-cache branch 2 times, most recently from f5b35b3 to 7a5d149 Compare October 21, 2024 06:58
@coot coot marked this pull request as ready for review October 21, 2024 07:29
@coot coot requested review from a team as code owners October 21, 2024 07:29
@coot coot changed the title github-actions: removed crossedOsArchive option github-actions: fixed caching Oct 21, 2024
@coot coot self-assigned this Oct 21, 2024
@coot coot enabled auto-merge October 21, 2024 07:34
We won't run cddl on Windows, running it on Hydra is enough.
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coot coot added this pull request to the merge queue Oct 21, 2024
Merged via the queue into master with commit b844ec3 Oct 21, 2024
12 checks passed
@coot coot deleted the coot/gha-cache branch October 21, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants