Fix "insert peer invariant test" #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Apr 3, 2023
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/PeerMetric.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/PeerMetric.hs
Show resolved
Hide resolved
coot
reviewed
Apr 6, 2023
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/PeerMetric.hs
Outdated
Show resolved
Hide resolved
coot
approved these changes
Apr 6, 2023
This test checks that newly added peer is never in the 20% worst performing peers (if there are at least 5 results). However we were not checking that the least had at least 5 results.
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 6, 2023
4480: Fix "insert peer invariant test" r=bolt12 a=bolt12 This test checks that newly added peer is never in the 20% worst performing peers (if there are at least 5 results). However we were not checking that the list had at least 5 results. Fixes #4092 Co-authored-by: Armando Santos <armando@well-typed.com>
|
Timed out. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 6, 2023
4480: Fix "insert peer invariant test" r=bolt12 a=bolt12 This test checks that newly added peer is never in the 20% worst performing peers (if there are at least 5 results). However we were not checking that the list had at least 5 results. Fixes #4092 Co-authored-by: Armando Santos <armando@well-typed.com>
|
Timed out. |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks that newly added peer is never in the 20% worst performing peers (if there are at least 5 results). However we were not checking that the list had at least 5 results.
Fixes #4092