Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NonP2P to P2P interop problem #4467

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Fix NonP2P to P2P interop problem #4467

merged 4 commits into from
Mar 23, 2023

Commits on Mar 23, 2023

  1. non-p2p: Differentiate between connections based on dir 

    Differentiate between incomming and outgoing connections.
P2P uses the server port as source port which meant that it was possible
for a non-p2p node to misstake in incomming connection from a p2p node
for an outgoing connection to the same node.
    @karknu
    karknu committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    490f4f6 View commit details
    Browse the repository at this point in the history

  2. Lower the time we refuse incomming connections for suspended peers 

    In p2p mode the same port number is used which means that p2p nodes
gets tangled up in the suspend peer logic.
P2P nodes will reconnect after 10s, by lowering the producer
suspensiontime from 20s to 1s p2p downstream peers aren't worse of than
non-p2p nodes.
    @karknu
    karknu committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    cde7a33 View commit details
    Browse the repository at this point in the history

  3. Make it clear when we can accept incomming cons 

    Let the server side know that it is permitted to accept new connections
from peer. Previously DisallowConnection was returned causing the
connection to be closed.
    @karknu
    karknu committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5530db7 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @karknu
    karknu committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a50479f View commit details
    Browse the repository at this point in the history