Send AwaitReply to prevent timeouts.
#432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niols
force-pushed
the
niols+tek/await-reply
branch
from
33ff682
to
66c88f7
Compare
|
I think I need some description of the problem that this PR is trying to solve. |
…ble and disable them in our test
tek
force-pushed
the
niols+tek/await-reply
branch
from
c4448a2
to
ef899cd
Compare
| trace "Added to current chain" | ||
| trace $ "New tip: " ++ condense newTipPoint | ||
| trace $ "New fragment: " ++ condense newFragment |
There was a problem hiding this comment.
Is this change intended?
There was a problem hiding this comment.
yes, that was too noisy and mostly redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #431.
When a ChainSync server is done serving its chain, it now sends an
AwaitReplymessage to the client so as to not get disconnected from too fast (typically, clients wait for 10s for a response, or 80-150s for a response afterAwaitReply).As a hack, servers also now return
AwaitReplywhen they fall behind the intersection of the client due to thePointSchedule's structure. It is not clear to us why this is accepted by a client.