Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump plutus and ledger dependencies for cardano-node-9.2 release #1207

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Bump plutus and ledger dependencies for cardano-node-9.2 release #1207

merged 2 commits into from
Aug 29, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 5, 2024 •
edited
Loading

  • Bump dependencies in preparation for the cardano-node-9.2 release
  • updated Ledger dependencies.
  • updated Plutus dependencies
  • updated ouroboros-network dependencies,
  • Propagate code changes resulting from the dependency bumps

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-plutus-1.32-and-ledger branch from ddd25f0 to 9050499 Compare August 5, 2024 20:07
@Jimbo4350 Jimbo4350 mentioned this pull request Aug 5, 2024
Open
6 tasks
jasagredo
jasagredo reviewed Aug 8, 2024
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
@jasagredo
Copy link
Contributor

I re-run the test-suite after input-output-hk/actions#28. Tests are failing with:

cardano-test: Unknown version: HardForkNodeToClientEnabled HardForkSpecificNodeToClientVersion3 (EraNodeToClientEnabled ByronNodeToClientVersion1 :* EraNodeToClientEnabled ShelleyNodeToClientVersion9 :* EraNodeToClientEnabled ShelleyNodeToClientVersion9 :* EraNodeToClientEnabled ShelleyNodeToClientVersion9 :* EraNodeToClientEnabled ShelleyNodeToClientVersion9 :* EraNodeToClientEnabled ShelleyNodeToClientVersion9 :* EraNodeToClientEnabled ShelleyNodeToClientVersion9 :* Nil)
CallStack (from HasCallStack):
  error, called at test/cardano-test/Test/Consensus/Cardano/Golden.hs:47:37 in ouroboros-consensus-cardano-0.18.0.0-inplace-cardano-test:Test.Consensus.Cardano.Golden
Test suite cardano-test: FAIL

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-plutus-1.32-and-ledger branch from 4071356 to c12c0a5 Compare August 8, 2024 16:45
jasagredo
jasagredo requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be merged until:

  • There are changelogs for ouroboros-consensus, strict-sop-core, sop-extras. Furthermore don't use the no changelog label. That label is exclusively for changes in testing code or cardano-tools. Any other change in the libraries must have a changelog entry.
  • The FIXUP commit is either reworded or fixup'ed into the other one.
  • The source-repository-package stanzas are gone.

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Aug 9, 2024 •
edited
Loading

There are changelogs for ouroboros-consensus, strict-sop-core, sop-extras. Furthermore don't use the no changelog label. That label is exclusively for changes in testing code or cardano-tools. Any other change in the libraries must have a changelog entry.

Can you point me to the documentation that explains how to generate changelogs.

@jasagredo
Copy link
Contributor

jasagredo commented Aug 9, 2024 •
edited
Loading

There are changelogs for ouroboros-consensus, strict-sop-core, sop-extras. Furthermore don't use the no changelog label. That label is exclusively for changes in testing code or cardano-tools. Any other change in the libraries must have a changelog entry.

Can you point me to the documentation that explains how to generate changelogs.

https://ouroboros-consensus.cardano.intersectmbo.org/docs/for-developers/ReleaseProcess It seems the header doesn't have an HTML anchor, but if you scroll down you will see Adding a changelog fragment.

Alternatively just duplicate one of the existing changelog fragments, rename the copy and modify the relevant section.

@jasagredo
Copy link
Contributor

There are changelogs for ouroboros-consensus, strict-sop-core, sop-extras. Furthermore don't use the no changelog label. That label is exclusively for changes in testing code or cardano-tools. Any other change in the libraries must have a changelog entry.

Can you point me to the documentation that explains how to generate changelogs.

Btw, I pointed you to how to create new changelog fragments, which is what this PR should do. You have to "generate changelogs" or more precisely "collect changelogs" when you are going to make the release which should be in a separate PR (or the bare minimum, in a separate commit at the end of this PR, but I would really appreciate if you can do it in a separate PR)

@jasagredo jasagredo linked an issue Aug 12, 2024 that may be closed by this pull request
Update to nothunks-0.2.1.0 #1190
Closed
@locallycompact locallycompact mentioned this pull request Aug 19, 2024
Closed
@Jimbo4350 Jimbo4350 changed the title Bump to plutus 1.32 and ledger xxx Bump plutus and ledger dependencies for cardano-node-9.2 release Aug 26, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-plutus-1.32-and-ledger branch 8 times, most recently from 6c5ed9e to b11217b Compare August 26, 2024 20:32
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-plutus-1.32-and-ledger branch from b11217b to 94dddd3 Compare August 26, 2024 20:34
jasagredo
jasagredo requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to address. And also the description of the PR should be meaningful.

ouroboros-consensus-cardano/ouroboros-consensus-cardano.cabal Outdated Show resolved Hide resolved
ouroboros-consensus-cardano/ouroboros-consensus-cardano.cabal Outdated Show resolved Hide resolved
ouroboros-consensus-cardano/ouroboros-consensus-cardano.cabal Outdated Show resolved Hide resolved
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs Outdated Show resolved Hide resolved
ouroboros-consensus/changelog.d/20240826_162230_jordan.millar_bump_plutus_1_32_and_ledger.md Outdated Show resolved Hide resolved
sop-extras/changelog.d/20240826_162106_jordan.millar_bump_plutus_1_32_and_ledger.md Outdated Show resolved Hide resolved
strict-sop-core/changelog.d/20240826_162006_jordan.millar_bump_plutus_1_32_and_ledger.md Outdated Show resolved Hide resolved
...-consensus-cardano/changelog.d/20240806_165201_damian.nadales_bump_plutus_1_32_and_ledger.md Outdated Show resolved Hide resolved
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-plutus-1.32-and-ledger branch from 94dddd3 to d464c05 Compare August 27, 2024 13:55
jasagredo
jasagredo requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description still is showing the template text.

ouroboros-consensus-cardano/CHANGELOG.md Show resolved Hide resolved
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-plutus-1.32-and-ledger branch 6 times, most recently from a55227b to 7f9754b Compare August 28, 2024 19:42
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-plutus-1.32-and-ledger branch from 7f9754b to cba804e Compare August 28, 2024 21:04
@disassembler disassembler added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 3da919f Aug 29, 2024
15 checks passed
@disassembler disassembler deleted the jordan/bump-plutus-1.32-and-ledger branch August 29, 2024 01:16
@amesgen amesgen mentioned this pull request Aug 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2024
@amesgen
GDD: use new AF.splitAtSlot (#1231)
242f513 
With #1207 merged, we can use `AF.splitAtSlot` which was introduced for
the use in the GDD by @facundominguez in
IntersectMBO/ouroboros-network#4884.
@amesgen amesgen mentioned this pull request Sep 26, 2024
Merged
@crocodile-dentist crocodile-dentist mentioned this pull request Oct 15, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrisby nfrisby nfrisby left review comments

@amesgen amesgen amesgen left review comments

@crocodile-dentist crocodile-dentist crocodile-dentist left review comments

@jasagredo jasagredo jasagredo approved these changes

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner

@RenateEilers RenateEilers Awaiting requested review from RenateEilers

Assignees
No one assigned
Labels
no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to nothunks-0.2.1.0
7 participants
@Jimbo4350 @jasagredo @dnadales @nfrisby @amesgen @crocodile-dentist @disassembler