cardano-testnet | Fix redundant error in creation of artifacts from failed test workspaces

[carbolymer]

Description

Sometimes after tests in cardano-testnet fail, workspace tar-ing fails as well with this cryptic error:

basename: extra operand ‘build-0-test-baf6b13ac090f575’

(see for example this build log https://github.com/IntersectMBO/cardano-node/actions/runs/11024038455/job/30616484791#step:16:14 )

This is annoying because you have to scroll through multiple lines of tar output to get to the actual test failures.

This PR aims to fix that.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • roundtrip tests
  • integration tests
    See Runnings tests for more details
• Any changes are noted in the CHANGELOG.md for affected package
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

[palas]

Looks good. I understand this PR basically adds double quotes around filenames passed to basename. That will prevent issues when, for example, there are spaces in paths

[carbolymer]

@palas I wasn't able to reproduce this locally on in CI for some reason. I understand that's what happening, that there's a space in the file name. I don't suspect find to insert spaces out of the blue there, so it looks like the directory has a space in it. I suspect that's the offender:

cardano-node/cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Transaction.hs

Line 47 in 72642b5

hprop_transaction = integrationRetryWorkspace 2 "simple transaction build" $ \tempAbsBasePath' -> H.runWithDefaultWatchdog_ $ do

because the basename complains about build-0-somehash.