Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nadia.chambers/parallel make 001 #5947

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NadiaYvette
Copy link
Contributor

Description

This passes -j flags down from MAKEFLAGS to nix and cabal to speed up builds for me. It also sets ERA=coay and there could be some wanting to change the semantics of how JOBS and NUM_PROCS signal whether to do parallel builds or not. If the Makefile is largely at our group's discretion, it makes sense to just merge the commits instead of carrying them around & cherry-picking them all the time.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

I don't believe CI uses this for test runs, so it's unlikely to have impacts on it.

@NadiaYvette NadiaYvette self-assigned this Aug 12, 2024
@NadiaYvette NadiaYvette requested a review from a team as a code owner August 12, 2024 16:00
@NadiaYvette NadiaYvette force-pushed the nadia.chambers/parallel-make-001 branch 4 times, most recently from 1dd1341 to 21fde6e Compare August 14, 2024 15:17
The NUM_PROCS variable isn't successfully initialized by the way the
command is invoked. The $(shell ...) primitive of make needs to be used.
nix.mk should not be touched even if it looks like an issue.
@NadiaYvette NadiaYvette force-pushed the nadia.chambers/parallel-make-001 branch from 21fde6e to a61a9e0 Compare August 26, 2024 14:43
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant