-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump network packages version #5409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
force-pushed
the
bolt12/update-network
branch
from
July 24, 2023 09:08
4115390
to
e337524
Compare
Now the Topology allows the user to not only specify the HotValency of its node's local root peers, via 'valency' ('hotValency' is now also valid) field, but also is able to specify the WarmValency, via 'warmValency' field. This field is optional and defaults to the value set in the 'valency'/'hotValency' field. The 'warmValency' value set should be greater than or equal to the one specified in 'valency'/'hotValency' otherwise 'valency'/'hotValency' will be truncated to this value. We recommend users to set 'warmValency' value to 'hotValency' + 1 in order to keep at least 1 backup peer to be promoted to hot in case something happens. Check IntersectMBO/ouroboros-network#4565 for more context on this WarmValency addition.
bolt12
force-pushed
the
bolt12/update-network
branch
from
July 24, 2023 09:33
e337524
to
1e24660
Compare
carbolymer
approved these changes
Jul 24, 2023
disassembler
approved these changes
Jul 24, 2023
NadiaYvette
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are straightforward & innocuous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compatibility with ouroboros-network-0.8.2.0
Added WarmValency option to the Topology file
Now the Topology allows the user to not only specify the HotValency of
its node's local root peers, via 'valency' ('hotValency' is now also
valid) field, but also is able to specify the WarmValency, via
'warmValency' field. This field is optional and defaults to the value
set in the 'valency'/'hotValency' field. The 'warmValency' value set
should be greater than or equal to the one specified in
'valency'/'hotValency' otherwise 'valency'/'hotValency' will be
truncated to this value. We recommend users to set 'warmValency' value to
'hotValency' + 1 in order to keep at least 1 backup peer to be promoted
to hot in case something happens.
Check IntersectMBO/ouroboros-network#4565
for more context on this WarmValency addition.