Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to write keys in bech32 #5058

Merged
merged 10 commits into from
Jun 1, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Apr 5, 2023

Add the ability to output keys in bech32 format.

The functionality was extracted from #1979 and refactored to make #5016 easier to implement.

The functionality was extracted because there was concern about backwards compatibility in that PR. This PR implements the change in a backwards compatible way by introducing a new optional flag.

This PR is limited to the writing of bech32. The reading of bech32 is to be implemented separately to avoid making this PR to large.

Changes:

  • Add --out-file argument to the shelley stake-pool id command.
  • Add --key-format-output argument to the following commands:
    • address key-gen
    • stake-address key-gen
    • node key-gen
    • node key-gen-KES
    • node key-gen-VRF
    • genesis create-staked
    • genesis create

Depends on #5049, #5057 and #5059. Please review those first.

Before those are merged, it is recommended to review this PR commit-by-commit starting from the commit with the message "Rename OutputFormat to PoolIdOutputFormat for clarity"

@newhoggy newhoggy force-pushed the newhoggy/option-to-write-keys-in-bech32 branch 5 times, most recently from 89f96b3 to dc7ef0d Compare April 5, 2023 12:28
@newhoggy newhoggy marked this pull request as ready for review April 5, 2023 12:28
@newhoggy newhoggy force-pushed the newhoggy/option-to-write-keys-in-bech32 branch 6 times, most recently from e218bc4 to 8059696 Compare April 13, 2023 03:37
@newhoggy newhoggy force-pushed the newhoggy/option-to-write-keys-in-bech32 branch 7 times, most recently from d6d3eea to 192e4e1 Compare April 19, 2023 09:30
@newhoggy newhoggy force-pushed the newhoggy/option-to-write-keys-in-bech32 branch 2 times, most recently from e4dee3d to 26f9ebc Compare April 27, 2023 01:24
@newhoggy newhoggy force-pushed the newhoggy/option-to-write-keys-in-bech32 branch from 26f9ebc to e76b16e Compare May 8, 2023 02:55
@newhoggy newhoggy force-pushed the newhoggy/option-to-write-keys-in-bech32 branch 2 times, most recently from ee6e722 to 34e4efb Compare May 11, 2023 14:40
@newhoggy newhoggy force-pushed the newhoggy/option-to-write-keys-in-bech32 branch from 34e4efb to 65e7a4a Compare June 1, 2023 04:15
@disassembler disassembler added this pull request to the merge queue Jun 1, 2023
Merged via the queue into master with commit 87a9caa Jun 1, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/option-to-write-keys-in-bech32 branch June 1, 2023 05:00
@gitmachtl
Copy link
Contributor

@newhoggy @disassembler the default for the --key-output-format is currently "text-envelope" (json), but the parameter help output for cardano-cli states that "bech32" is the default mode:

 --key-output-format STRING
                           Optional key output format. Accepted output formats
                           are "text-envelope" and "bech32" (default is
                           "bech32").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants