Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench: support new tracing & add a Plutus workload profile #3851

Merged
merged 28 commits into from
May 19, 2022
Merged

workbench: support new tracing & add a Plutus workload profile #3851

merged 28 commits into from
May 19, 2022

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented May 10, 2022 •
edited
Loading

  1. workbench: support new tracing & massage it to conform with legacy in terms of configuration
  2. locli: support new tracing
  3. new tracing: restore some structural compatibility with legacy
  4. workbench: forge-stress-plutus profile
  5. add @mgmeier to benchmarking things
  6. Makefile tweaks for better automation
  7. new tracing: add node state log messages
  8. workbench: further improve derived calculations in profiles
  9. a bunch of small workbench improvements here and there

@deepfire deepfire force-pushed the bench-forgestress branch 4 times, most recently from 487abe9 to 8d273ee Compare May 11, 2022 22:02
@deepfire deepfire force-pushed the bench-forgestress branch 11 times, most recently from 9e02322 to 0f68cf5 Compare May 14, 2022 19:29
jutaro
jutaro requested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@jutaro jutaro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Serge, think the API change is not necessary. But maybe I'm wrong with this. Let us speak about this in our meeting. Some more questions/comments.

cardano-node/src/Cardano/Node/Tracing/API.hs Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/API.hs Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Documentation.hs Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Tracers.hs Outdated Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Tracers.hs Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Tracers/ForgingThreadStats.hs Show resolved Hide resolved
cardano-node/src/Cardano/Node/Tracing/Tracers/Peer.hs Show resolved Hide resolved
doc/new-tracing/tracers_doc_generated.md Show resolved Hide resolved
trace-dispatcher/src/Cardano/Logging/Trace.hs Show resolved Hide resolved
trace-dispatcher/src/Cardano/Logging/Trace.hs Show resolved Hide resolved
@deepfire deepfire force-pushed the bench-forgestress branch 4 times, most recently from 51859f6 to c25d7da Compare May 19, 2022 00:19
@deepfire
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 19, 2022
@iohk-bors @deepfire
Merge #3851
21b81c0 
3851: workbench:  support new tracing & add a Plutus workload profile r=deepfire a=deepfire

1. workbench: support new tracing & massage it to conform with legacy in terms of configuration
1. locli: support new tracing
1. new tracing: restore some structural compatibility with legacy
1. workbench: forge-stress-plutus profile
1. add `@mgmeier` to benchmarking things
1. Makefile tweaks for better automation
1. new tracing: add node state log messages
1. workbench: further improve derived calculations in profiles
1. a bunch of small workbench improvements here and there

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Canceled.

@deepfire
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 19, 2022
@iohk-bors @deepfire
Merge #3851
606e26a 
3851: workbench:  support new tracing & add a Plutus workload profile r=deepfire a=deepfire

1. workbench: support new tracing & massage it to conform with legacy in terms of configuration
1. locli: support new tracing
1. new tracing: restore some structural compatibility with legacy
1. workbench: forge-stress-plutus profile
1. add `@mgmeier` to benchmarking things
1. Makefile tweaks for better automation
1. new tracing: add node state log messages
1. workbench: further improve derived calculations in profiles
1. a bunch of small workbench improvements here and there

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Canceled.

@deepfire
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 19, 2022
@iohk-bors @deepfire
Merge #3851
ca3c82b 
3851: workbench:  support new tracing & add a Plutus workload profile r=deepfire a=deepfire

1. workbench: support new tracing & massage it to conform with legacy in terms of configuration
1. locli: support new tracing
1. new tracing: restore some structural compatibility with legacy
1. workbench: forge-stress-plutus profile
1. add `@mgmeier` to benchmarking things
1. Makefile tweaks for better automation
1. new tracing: add node state log messages
1. workbench: further improve derived calculations in profiles
1. a bunch of small workbench improvements here and there

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@deepfire
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Already running a review

@deepfire
Copy link
Contributor Author

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Canceled.

@deepfire
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 19, 2022
@iohk-bors @deepfire
Merge #3851
0446c02 
3851: workbench:  support new tracing & add a Plutus workload profile r=deepfire a=deepfire

1. workbench: support new tracing & massage it to conform with legacy in terms of configuration
1. locli: support new tracing
1. new tracing: restore some structural compatibility with legacy
1. workbench: forge-stress-plutus profile
1. add `@mgmeier` to benchmarking things
1. Makefile tweaks for better automation
1. new tracing: add node state log messages
1. workbench: further improve derived calculations in profiles
1. a bunch of small workbench improvements here and there

Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@deepfire
Copy link
Contributor Author

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Canceled.

@deepfire
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 19, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 7bf7335 into master May 19, 2022
@iohk-bors iohk-bors bot deleted the bench-forgestress branch May 19, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jutaro jutaro jutaro approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@nc6 nc6 Awaiting requested review from nc6

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@coot coot Awaiting requested review from coot

@MarcFontaine MarcFontaine Awaiting requested review from MarcFontaine

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepfire @jutaro @Jimbo4350