cardano-tracer-3637: correct JSON logs. #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutaro
approved these changes
Feb 23, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 23, 2022
3640: cardano-tracer-3637: correct JSON logs. r=denisshevchenko a=denisshevchenko
`@jutaro` reported:
Currently the data field in JSON formats are strings, which are escaped:
```
{"host":"deusXmachina", "data":"{\"kind\":\"OpenEvent.OpenedImmutableDB\"}","thread":"5"}
```
But data should not be a string, but a JSON object:
```
{"host":"deusXmachina", "data":{"kind":"OpenEvent.OpenedImmutableDB"}, "thread":"5"}
```
Additionally, now the order of JSON-pairs is the same as in `trace-dispatcher`.
Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Feb 23, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jutaro reported:
Currently the data field in JSON formats are strings, which are escaped:
But data should not be a string, but a JSON object:
Additionally, now the order of JSON-pairs is the same as in
trace-dispatcher.