[FR] - Do not prepend change output when balancing transaction #3725
Closed
Assignees
Labels
comp: cardano-api
enhancement
New feature or request
user type: external
Created by an external user
Comments
LudvikGalois
pushed a commit
that referenced
this issue
Aug 16, 2022
It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725
LudvikGalois
pushed a commit
that referenced
this issue
Aug 16, 2022
It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725
iohk-bors bot
added a commit
that referenced
this issue
Aug 17, 2022
4343: Append change instead of prepending it r=newhoggy a=LudvikGalois It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725 Co-authored-by: Robert 'Probie' Offner <robert.offner@iohk.io>
Jimbo4350
pushed a commit
that referenced
this issue
Sep 29, 2022
It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725
disassembler
pushed a commit
that referenced
this issue
Sep 29, 2022
It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725
dorin100
added
user type: external
disassembler
pushed a commit
that referenced
this issue
Oct 25, 2022
It's desirable for a client to be able to predict the index of outputs. As such we append change to the end so that the index of other outputs doesn't changed based on whether there's change or not. Resolves #3725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Internal/External
External otherwise.
Area
Plutus Related to Plutus Scripts (Alonzo).
Describe the feature you'd like
makeTransactionAutoBalancewhich is used in Cardano-CLI prepends change output breaking original outputs indexing.https://github.com/input-output-hk/cardano-node/blob/9c991b0c610b5a0f2b58e0c381e9ac7c4b11ac78/cardano-api/src/Cardano/Api/Fees.hs#L975
Append change output instead.
Additional context / screenshots
Stable outputs indexing allows dApp developers to write more efficient Plutus validators by passing an index of a particular input/output with a redeemer rather than making an expensive full search through all inputs/outputs.
Example:
https://github.com/ergolabs/cardano-dex-contracts/blob/34aa1723174abb1700d0b78e883e9c74b8f50948/src/ErgoDex/PContracts/PSwap.hs#L70
The text was updated successfully, but these errors were encountered: