Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement POC of same number of argumetns for PlutusV3 #4271

Closed
wants to merge 1 commit into from

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Apr 16, 2024

Description

Proof-of-Concept: making the same number (three) of arguments for PlutusV3, regardless of plutus purpose.

CI is still failing because tests have not been adjusted to account for this change.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins
Copy link
Collaborator Author

lehins commented Apr 26, 2024

This approach is not sufficient for CIP-0069, because it is missing the desired feature of making the spending datum optional, which doe s require changing the ledger rules. Therefore we decided to go with a proper solution, even if it means it will take longer to get it done.

@lehins lehins closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant