Addition of lenses for PParams #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/pparams-lens
branch
2 times, most recently
from
a3a0b49
to
afa8445
Compare
lehins
requested review from
JaredCorduan and
Soupstraw
and removed request for
JaredCorduan
Soupstraw
reviewed
Jan 11, 2023
Soupstraw
reviewed
Jan 11, 2023
lehins
force-pushed
the
lehins/pparams-lens
branch
2 times, most recently
from
1814588
to
67ea7d0
Compare
lehins
force-pushed
the
lehins/pparams-lens
branch
from
67ea7d0
to
7af79f9
Compare
Soupstraw
reviewed
Jan 12, 2023
Soupstraw
reviewed
Jan 12, 2023
Soupstraw
reviewed
Jan 12, 2023
lehins
force-pushed
the
lehins/pparams-lens
branch
from
7af79f9
to
5f267c4
Compare
Soupstraw
reviewed
Jan 12, 2023
eras/shelley/impl/src/Cardano/Ledger/Shelley/API/ByronTranslation.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/GenesisDelegation.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/GenesisDelegation.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/Mir.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/MirTransfer.hs
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/RulesTests.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Jan 12, 2023
eras/babbage/test-suite/src/Test/Cardano/Ledger/Babbage/Examples/Consensus.hs
Show resolved
Hide resolved
JaredCorduan
approved these changes
Jan 12, 2023
lehins
force-pushed
the
lehins/pparams-lens
branch
from
5f267c4
to
26b4305
Compare
* Added `EraPParams` `AlonzoEraPParams` and `BabageEraPParams` with lenses that can access and manipulate both `PParams` and `ParamsUpdate` for each era. * Introduced `upgradePParams` and `downgradePParams`, which loosely correspond to `extendPP` and `retractPP`. * Removed all occurrences of HasField from all the eras. * Extracted `Era` related code and `TranslateEra` related code from `Cardano.Ledger.Core` into `Cardano.Ledger.Core.Era` and `Cardano.Ledger.Core.Translation` respectfully * Moved `PreviousEra` type family into `Era` type class. * Defined an `Era` instance for new `ByronEra` type * Concrete PParams types for each era had their fields renamed to follow the convention used throughout the codebase * Adjust transaction generation in the travce generator to work for eras beyond Mary * Got rid of `ShelleyTest` and `UsesPP` type synonyms
It is acceptable to turn off the warning for the whole package for ghc-8.10 since we are developing with ghc-9.2 and we have CI for both of those GHC versions, so we will definitely catch any name shadowing warnings that aren't related to the bug.
* According to Github documentation cache action will already automatically look into `master` branch cache, however it will never look into caches for other branches. So, previous logic was a bit faulty * Enable trigger on pushes to master, this way we can have a build after each PR is merged.
lehins
force-pushed
the
lehins/pparams-lens
branch
from
26b4305
to
9e2a28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addition of
EraPParams,AlonzoEraPParamsandBabageEraPParamstype classes with lenses that can access and manipulate bothPParamsandParamsUpdate. Each type class requires implementation lenses for thePParamsHKDtype, which are later used for defining specific lenses for PParams and PParamsUpdate respectfullyHKD types
ShelleyPParams,AlonzoPParamsandBabbagePParamsnow become internal, for the most part and thePParams+PParamsUpdateare the newtype wrappers around the era specific internal HKD type. All operations on PParams should be done with lenses from now on.Other notable things in this PR:
Ordinstances forAlonzoPParamsandBabbagePParamsby introducing an internal `OrdExUniits type.To/FromJSONinstances to prevent the from being orphanCostModelsintoCardano.Ledger.Alozno.ScriptsfromCardano.Ledger.Alozno.PParamsPoolEnvfields strictByronErathat has anErainstance. This is done mostly for completeness, but also to allow getting protocol version from the type level. Also this allowedPreviousEratype family to be moved intoEratype class.Cardano.Ledger.{EraName}.Coremodule. It was discussed before, but wasn't fully implemented.Fixes #2927
Checklist
fourmolu(which can be run withscripts/fourmolize.sh