Added JSON and CBOR instances to ConwayGenesis #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/conway-cbor-instances
branch
4 times, most recently
from
2cc9bff
to
3cf074f
Compare
Soupstraw
force-pushed
the
jj/conway-cbor-instances
branch
from
2d37b9a
to
c7b9511
Compare
9 tasks
Soupstraw
force-pushed
the
jj/conway-cbor-instances
branch
3 times, most recently
from
518c675
to
2fecc9f
Compare
Soupstraw
force-pushed
the
jj/conway-cbor-instances
branch
from
2fecc9f
to
e552d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ToJSON,ToCBORandFromCBORinstances toConwayGenesis. It also adds a test suite and round-trip tests to Conway era.The
ToJSONinstance forConwayGenesiscurrently outputs a JSON object containing a single fieldgenDelegs, which contains the JSON data for theGenDelegs.ConwayGenesisis encoded in CBOR just asGenDelegs(via the generic ToCBOR and FromCBOR instance for newtypes).closes #3021