Ensure Babbage TxOut decoder can't fail due to malformed Ptr #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only intended for TxBody to be causing a deserialization error on malformed Ptr, not the TxOut in the LedgerState or TxBody in eras prior to Babbage.
JaredCorduan
approved these changes
Jul 6, 2022
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Jul 7, 2022
4146: Update ledger to tip of release/1.0.0 r=Jimbo4350 a=JaredCorduan This fixes a bug whereby nodes always re-sync from the start when the last ledger snapshot was in the Babbage era. See IntersectMBO/cardano-ledger#2897 (`release/1.0.0` was branched off of `ce3057e0863304ccb3f79d78c77136219dc786c6` and cherry-picked the commit from the ledger PR 2897). Co-authored-by: Jared Corduan <jared.corduan@iohk.io>
jbgi
pushed a commit
to IntersectMBO/cardano-world
that referenced
this pull request
Jul 11, 2022
4146: Update ledger to tip of release/1.0.0 r=Jimbo4350 a=JaredCorduan This fixes a bug whereby nodes always re-sync from the start when the last ledger snapshot was in the Babbage era. See IntersectMBO/cardano-ledger#2897 (`release/1.0.0` was branched off of `ce3057e0863304ccb3f79d78c77136219dc786c6` and cherry-picked the commit from the ledger PR 2897). Co-authored-by: Jared Corduan <jared.corduan@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only intended for TxBody to be causing a deserialization error
on malformed Ptr, not the TxOut in the LedgerState or TxBody in eras prior
to Babbage.