Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running a db-sync with and then without prune-tx-out #1486

Closed
Tracked by #1420
kderme opened this issue Aug 18, 2023 · 0 comments
Closed
Tracked by #1420

Avoid running a db-sync with and then without prune-tx-out #1486

kderme opened this issue Aug 18, 2023 · 0 comments

Comments

@kderme
Copy link
Contributor

kderme commented Aug 18, 2023

If prune flag is enabled and then db-sync is stopped all future executions of db-sync should still have this flag. Otherwise, it is considered bad usage and can cause crashes and db-sync has no guard against it. The default db-sync schema can be extended to log that at some point this flag was enabled. This requires schema changes so it needs a major bump, eg 13.2.

Now that a extra_migration table exists, after #1484, uisage of this flags can be logged there and checked on db-sync initiation.

@kderme kderme changed the title If prune flag is enabled and then db-sync is stopped all future executions of db-sync should still have this option. Otherwise, it is considered bad usage and can cause crashes and db-sync has no guard against it. The default db-sync schema can be extended to log that at some point this flag was enabled. This requires schema changes so it needs a major bump, eg 13.2. Avoid running a db-sync with and then without prunt-tx-out Aug 18, 2023
@kderme kderme changed the title Avoid running a db-sync with and then without prunt-tx-out Avoid running a db-sync with and then without prune-tx-out Aug 22, 2023
Cmdv added a commit that referenced this issue Aug 23, 2023
Cmdv added a commit that referenced this issue Aug 24, 2023
Cmdv added a commit that referenced this issue Aug 25, 2023
Cmdv added a commit that referenced this issue Sep 1, 2023
@kderme kderme closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant