Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose symbols required by hash check in transaction build in cardano-cli #661

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 22, 2024

Changelog

- description: |
    Exposed `GovAction` and `Constitution` types and constructors required by hash check in `transaction build` in `cardano-cli`
  type:
  - feature

Context

Work to check anchor data in transactions being build with transaction build command of
cardano-cli requires inspecting the GovAction and Constitution types, which are currently not exposed by cardano-api but by cardano-ledger-api (see branch hash-check-in cardano-cli ). In order to avoid transitive dependencies, this PR exposes the required types and constructors.

How to trust this PR

Tiny PR. I just would ensure it is right to export these, that they are not exported anywhere else, and that they are imported in the right way.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit fcde6bc Oct 22, 2024
25 checks passed
@palas palas deleted the expose-symbols-required-by-hash-check branch October 22, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - Add File Hash Validation when Building Transaction
2 participants