Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conway parameters in ProtocolParameters #532

Closed
wants to merge 2 commits into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented May 7, 2024

Changelog

- description: |
    Add Conway parameters in ProtocolParameters
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fix of IntersectMBO/cardano-cli#729

I'm not exactly sure of the design, confirmation or negation welcome 🙏

How to trust this PR

  • I ran cabal test all on CLI, with a SRP to this PR; and all tests passed
  • I executed tests of cardano-node with this PR and they pass: CI only cardano-node#5826

Checklist

@smelc
Copy link
Contributor Author

smelc commented May 13, 2024

Probably superseded by IntersectMBO/cardano-cli#758 and will be closed soon

@smelc
Copy link
Contributor Author

smelc commented May 21, 2024

Superseded by IntersectMBO/cardano-cli#758, so closing

@smelc smelc closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant