Fix datum conversion in 'fromShelleyTxOut' when using 'ShelleyBasedEr…

…aAlonzo' as input
IntersectMBO · Aug 10, 2024 · 9025ae3 · 9025ae3
1 parent 1fb6947
commit 9025ae3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/cardano-api/internal/Cardano/Api/Tx/Body.hs b/cardano-api/internal/Cardano/Api/Tx/Body.hs
@@ -743,7 +743,13 @@ fromShelleyTxOut sbe ledgerTxOut = shelleyBasedEraConstraints sbe $ do
     ShelleyBasedEraMary ->
       TxOut addressInEra txOutValue TxOutDatumNone ReferenceScriptNone
     ShelleyBasedEraAlonzo ->
-      TxOut addressInEra txOutValue TxOutDatumNone ReferenceScriptNone
+      TxOut
+        addressInEra
+        txOutValue
+        (fromAlonzoTxOutDatumHash AlonzoEraOnwardsAlonzo datumHashM)
+        ReferenceScriptNone
+     where
+      datumHashM = ledgerTxOut ^. L.dataHashTxOutL
     ShelleyBasedEraBabbage ->
       TxOut
         addressInEra
@@ -786,6 +792,13 @@ toAlonzoTxOutDatumHash (TxOutDatumHash _ (ScriptDataHash dh)) = SJust dh
 toAlonzoTxOutDatumHash (TxOutDatumInline{}) = SNothing
 toAlonzoTxOutDatumHash (TxOutDatumInTx' _ (ScriptDataHash dh) _) = SJust dh
 
+fromAlonzoTxOutDatumHash
+  :: AlonzoEraOnwards era
+  -> StrictMaybe (Plutus.DataHash StandardCrypto)
+  -> TxOutDatum ctx era
+fromAlonzoTxOutDatumHash _ SNothing = TxOutDatumNone
+fromAlonzoTxOutDatumHash w (SJust hash) = TxOutDatumHash w $ ScriptDataHash hash
+
 toBabbageTxOutDatum
   :: (L.Era (ShelleyLedgerEra era), Ledger.EraCrypto (ShelleyLedgerEra era) ~ StandardCrypto)
   => TxOutDatum ctx era

diff --git a/cardano-api/test/cardano-api-test/Test/Cardano/Api/Ledger.hs b/cardano-api/test/cardano-api-test/Test/Cardano/Api/Ledger.hs
@@ -63,6 +63,12 @@ prop_roundtrip_scriptdata_plutusdata = H.property $ do
   sd <- getScriptData <$> forAll genHashableScriptData
   H.tripping sd toPlutusData (Identity . fromPlutusData)
 
+prop_roundtrip_ledger_txout :: Property
+prop_roundtrip_ledger_txout = H.property $ do
+  forM_ [minBound .. maxBound] $ \(AnyShelleyBasedEra era) -> do
+    txOut <- forAll $ genTxOutUTxOContext era
+    txOut H.=== fromShelleyTxOut era (toShelleyTxOut era txOut)
+
 -- -----------------------------------------------------------------------------
 
 tests :: TestTree
@@ -72,4 +78,5 @@ tests =
     [ testProperty "roundtrip Address CBOR" prop_roundtrip_Address_CBOR
     , testProperty "roundtrip ScriptData" prop_roundtrip_scriptdata_plutusdata
     , testProperty "script data bytes preserved" prop_original_scriptdata_bytes_preserved
+    , testProperty "roundtrip Ledger TxOut" prop_roundtrip_ledger_txout
     ]