Features/embeded json schema #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythooonUser
approved these changes
Mar 10, 2021
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "$schema": "http://delverengine.com/jsonschema/current/filetypes/animations.dat", | |||
There was a problem hiding this comment.
I'm getting the following IDE error: Property $schema is not allowed.
There was a problem hiding this comment.
Correct. Because the current deployed versions of the schemas do not allow the property. 😄
This will be resolved after merge and updating the live schema.
There was a problem hiding this comment.
Ah, my bad. Okay then!
|
The point of adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the "$schema" property to our JSON schema so it's way easier for text editors can do the right thing. I'd love to have this feature for the next tutorial video, so I'm making it true. 😝