Fixes issue with keybinds not working after loading the game #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythooonUser
approved these changes
Feb 5, 2021
| Options.SetInputOptions(controllerMapping.get(controller)); | ||
| String controllerName = controller.getName().toLowerCase(); | ||
|
|
||
| if (controllerName.contains("microsoft corporatio controller")) { |
There was a problem hiding this comment.
This is the actual name. 🙃
There was a problem hiding this comment.
Thanks for the fix Joshua!
corporation?
Microsoft probably trying to recreate the Roman empire or something :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue with custom keybinds not working after relaunching the game. The issue was keybinds are set by the GamepadManager called in
Game.init()which is called beforeOptions.loadOptions()inSplashScreen.java. This results in using a temp instance of Options which are all the default keybinds.Fix
I decoupled setting gamepad bindings and key bindings. We set the keybindings whenever we load the options file and load the gamepad bindings once the GamepadManager has been initialized.
Fixes #201