Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Mods Button On Main Menu Not Translatable #173

Merged
merged 8 commits into from
Mar 4, 2021
Merged

[Feature] Mods Button On Main Menu Not Translatable #173

merged 8 commits into from
Mar 4, 2021

Conversation

PythooonUser
Copy link
Contributor

@PythooonUser PythooonUser commented Nov 8, 2020 •
edited
Loading

grafik

Summary

Fixes #174. Adds screens.MainMenuScreen.modsButton string translation for the mods button on the main menu.

And some 💄s.

@PythooonUser PythooonUser changed the title Adding translation for the mods button Mods Button On Main Menu Not Translatable Nov 8, 2020
Felix Siebeneicker added 3 commits November 18, 2020 16:40
@PythooonUser PythooonUser changed the title Mods Button On Main Menu Not Translatable [Feature] Mods Button On Main Menu Not Translatable Jan 8, 2021
joshuaskelly
joshuaskelly approved these changes Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@joshuaskelly joshuaskelly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, otherwise looks good! 👍

Dungeoneer/src/com/interrupt/dungeoneer/screens/MainMenuScreen.java Outdated Show resolved Hide resolved
joshuaskelly
joshuaskelly approved these changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@joshuaskelly joshuaskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for addressing my feedback.

@joshuaskelly joshuaskelly merged commit 70814fd into Interrupt:master Mar 4, 2021
@PythooonUser PythooonUser deleted the bugfix/mods-button-translation branch March 4, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaskelly joshuaskelly joshuaskelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Delver] Mods Button On Main Menu Not Translatable
2 participants
@PythooonUser @joshuaskelly