Adding missing string table entry #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythooonUser
approved these changes
Nov 3, 2020
| @@ -71,7 +72,9 @@ protected void addAttribute(Table table, final String text, final Integer curren | |||
| attributeName.setWrap(true); | |||
| attributeName.setColor(new Color(0.298039215686275f, 0.12156862745098f, 0.12156862745098f, 1f)); | |||
|
|
|||
| final Label value = new Label("Current: " + currentValue.toString(), skin.get(LabelStyle.class)); | |||
| String currentStatValueLabel = StringManager.get("overlays.LevelUpOverlay.currentStatValueLabel"); | |||
| currentStatValueLabel = MessageFormat.format(currentStatValueLabel, currentValue,toString()); | |||
There was a problem hiding this comment.
Did you mean currentValue.toString()?
There was a problem hiding this comment.
Yes, yes I did. 🤦
Though I might not need it?
There was a problem hiding this comment.
Puh, I don't know? From the usage I think currentValue comes in as an integer, right? And maybe the toString method is called automatically?
However, the level up screen is nothing that is called every frame and, therefore, I guess, better safe than sorry :D
There was a problem hiding this comment.
MessageFormat.format() takes a string and an arbitrary number of Objects as params, so I've just dropped ,toString()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added missing string table entry so translators can translate: "Current: X"