Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting to .bin extension when saving #107

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

PythooonUser
Copy link
Contributor

grafik

Summary

Fixes #106. Defaulting to .bin extension when saving.

@PythooonUser
Copy link
Contributor Author

Might also add to that: When explicitly removing any extension the .bin extension should be added implicitly.

@joshuaskelly
Copy link
Collaborator

I'd be fine with appending .bin if there is no extension provided.

@PythooonUser
Copy link
Contributor Author

Alright, a default extension .bin is now also added when no extension given.

Copy link
Collaborator

@joshuaskelly joshuaskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! 👍

@joshuaskelly joshuaskelly merged commit 4d96e2d into Interrupt:master Sep 29, 2020
evrimoztamur pushed a commit to evrimoztamur/delverengine that referenced this pull request Sep 30, 2020
* Using .bin extension by default

* Implicitly adding .bin extension

* Adjusting namings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defaulting to .bin format when saving
2 participants