Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check CUDA_DEVICE_MAX_CONNECTIONS and TORCH_NCCL_AVOID_RECORD_STREAMS #379

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sallyjunjun
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

In GPU environment, CUDA_DEVICE_MAX_CONNECTIONS and TORCH_NCCL_AVOID_RECORD_STREAMS should be set to 1, to achieve the best performance.

Modification

modify check_cuda_env function to assert error when CUDA_DEVICE_MAX_CONNECTIONS and TORCH_NCCL_AVOID_RECORD_STREAMS are not set correctly.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@sallyjunjun sallyjunjun force-pushed the optimize-code branch 3 times, most recently from 74d8c7d to 91b6ad5 Compare December 2, 2024 10:45
@sallyjunjun sallyjunjun force-pushed the optimize-code branch 2 times, most recently from 5825926 to 6a33277 Compare December 9, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants