Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipeline): Zero Bubble V Shape Memory Efficient Editon #357

Merged
merged 11 commits into from
Oct 29, 2024

Conversation

li126com
Copy link
Collaborator

@li126com li126com commented Oct 26, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

重排ZBV以消除cool down阶段由于W延迟计算造成的显存累计开销。此版本与overlap grad , param以及isp overlap均兼容。

ZBV origin:
image

cooldown rearrange:
本版本在optimizer step不使用post validation
image

性能及显存

配置:internlm2-7B, micro_num=8, dp=2, pp=4, overlap sync grad.
显卡:8卡,A800

1f1b:
tgs = 2565
image

zbv:
tgs = 3081
image

精度测试

pp4:
image

dp2_tp2_pp4_msp:
image

dp2_tp2_pp4_wp2_isp_overlap
image

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@li126com li126com changed the title Feat(pipeline): Zero Bubble V Shape Memory Efficient Editon feat(pipeline): Zero Bubble V Shape Memory Efficient Editon Oct 28, 2024
@sunpengsdu sunpengsdu merged commit 330c03a into InternLM:develop Oct 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants