Allow custom sound indices in SoundReader.GetAudioClip. #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed for custom enemies to pass new sounds in EnemySounds
|
This is good, thank you Kab. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used for custom enemies to pass new sounds in EnemySounds (ex: by providing
1000.mp3and using1000as the attack sound in its Mobile structure). The value is forwarded toSoundReplacement, which handles non-standard values just fine.I added some extra sanitization for negative numbers in BsaFile, because
SoundClips.Noneis-1, which is often used as a default.