Moved EnemyEntity methods to FormulaHelper for mod override #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Group, GetLanguageSkill, GetWeightInClassicUnits
|
I think this one is OK despite the feature lock. The original methods are still in place with their original signatures, I don't think this will break any mods calling those public methods. Is that right, Kab? |
|
Yeah the whole point of this approach was to avoid having to refactor any code. This only adds functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FormulaHelpers for EnemyEntity:
The first is necessary for the functioning of Pacify and Dispel spells effects to work on custom enemies. The second is for the language pacification feature.
The third one, I don't plan on using just yet, but I felt I might as well add it for completion.