Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS compatibility #7

Merged
merged 4 commits into from
Sep 6, 2022
Merged

macOS compatibility #7

merged 4 commits into from
Sep 6, 2022

Conversation

ruberith
Copy link
Contributor

@ruberith ruberith commented Apr 8, 2022

These adaptations allow builds using Clang on recent versions of macOS (tested on Apple silicon):

  • Recent versions of CMake automatically determine the correct flags for OpenMP and provide a target to link against. Nevertheless, Clang does not include an OpenMP implementation on macOS by default, but the user can easily install a build of LLVM libomp (e.g. via Homebrew) to be shared by all projects requiring OpenMP which is then detected by CMake.
  • Clang is also missing an implementation of the Parallel STL algorithms, so I suggest to add oneDPL as a dependency. oneDPL provides the same interface as the standard library to TBB (which is used by GCC) among others and can be installed by the user in a similar fashion to libomp.

Copy link
Member

@digitalillusions digitalillusions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, need to confirm on windows and linux. then it can also be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants