[#406] Improve library performance when creating publisher restrictions #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sevriugin, can you review this and also #409, #404 and #403 please? |
|
In general LGTM, I have doubts regarding Array.from it could be an issue if some publisher is still using IE11 |
@sevriugin Thank you for the review, |
The BST isn't good to satisfy perf requirement
marco-prontera
force-pushed
the
perf/#406
branch
from
d751942
to
f584491
Compare
|
Hello @aitnitishshelage Following yesterday's release, are there any plans to merge this one? |
sevriugin
merged commit 89a93da
into
InteractiveAdvertisingBureau:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #406
The goal of this PR is to improve the performance for encoding and decoding a String when using the Purposes Restrictions. There is no need to say that this is important since this impact to everything (at least everything that depend on a consent) in a website.
I tried also with the new vendorList v3 - version 11 https://vendor-list.consensu.org/v3/vendor-list.json and these are the performances before the changes I propose:
ENCODING (before)
DECODING (before)
After the changes I propose in this PR the performances are the following:
ENCODING (after changes)
DECODING (after changes)