Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependent Fields Support #27

Merged

Conversation

dmason30
Copy link

@dmason30 dmason30 commented Mar 7, 2023

Adds the ability to use ->dependsOn(...) with this field.

@alies-dev alies-dev self-requested a review March 7, 2023 17:54
Copy link
Member

@alies-dev alies-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, cool! Thanks a lot, @dmason30 !

Unfortunately, I can't test it manually this week, but I don't work to block such awesome work. Can you please confirm it works in following modes:

  • index page (even if the column is not visible - JS doesn't produce errors)
  • show/details page (where we display content in iframe)
  • create mode
  • edit mode with both email and web display modes

If it works without any issues - I just need a confirmation from you and will tag a new release today. Great work! 🚀

@dmason30
Copy link
Author

dmason30 commented Mar 7, 2023

@lptn The dependsOn logic only applies to to create/edit and yes I can confirm it works on create/edit and show and the index does not show any errors.

@alies-dev
Copy link
Member

Cool, thanks a lot!

@alies-dev alies-dev merged commit 9a8f87b into InteractionDesignFoundation:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants