Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grow music inventory dynamically #4583

Merged
merged 1 commit into from
Jan 26, 2025
Merged

fix: grow music inventory dynamically #4583

merged 1 commit into from
Jan 26, 2025

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #4567

Description

not tested, should work (i did test the math part though)

Submitter Checklist
Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner January 25, 2025 20:35
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jan 25, 2025
@NotMyFault NotMyFault requested a review from a team January 25, 2025 20:36
SirYwell
SirYwell approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If we update to Java 21, we can also use Math.ceilDiv there

@NotMyFault NotMyFault merged commit 974c639 into main Jan 26, 2025
8 checks passed
@NotMyFault NotMyFault deleted the fix/4567 branch January 26, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@SirYwell SirYwell SirYwell approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBounds exception happening with /p music
3 participants
@PierreSchwang @SirYwell @NotMyFault