Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.21.4 update #4579

Closed
wants to merge 1 commit into from
Closed

1.21.4 update #4579

wants to merge 1 commit into from

Conversation

UndeadStudios
Copy link

@UndeadStudios UndeadStudios commented Jan 21, 2025 •
edited
Loading

nvm

@UndeadStudios UndeadStudios requested a review from a team as a code owner January 21, 2025 16:04
@dordsor21
Copy link
Member

This breaks P2 support on all previous versions

@UndeadStudios
Copy link
Author

This breaks P2 support on all previous versions

true didnt think about that just wanted 1.21.4 support

@PierreSchwang
Copy link
Member

Using / comparing the id or namespaced key should work ig. Should be put in constants though

@PierreSchwang
Copy link
Member

#4582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UndeadStudios @dordsor21 @PierreSchwang