Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't heal dead players #4407

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Don't heal dead players #4407

merged 1 commit into from
Apr 21, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

Skips dead players (health < 0.1) from the healing scheduling task

Fixes #4406

Description

As of now, dead players are healed by the heal-flag even when they are dead (open respawn screen). The healthbar fills, while in the respawn screen - and it seems the server does not like that behavior at all. In my case, I could not click on respawn (button stay's dark gray / in pressed state). When clicking on "Back to Title Screen" and then "Respawn" it just put's me back into the world as if I did not die at all.

Just ignoring dead players seem to fix that behavior.

Submitter Checklist

Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner April 20, 2024 14:09
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Apr 20, 2024
@NotMyFault NotMyFault requested a review from a team April 20, 2024 14:24
@NotMyFault NotMyFault merged commit c239908 into main Apr 21, 2024
8 checks passed
@NotMyFault NotMyFault deleted the fix/healDeadPlayers branch April 21, 2024 11:03
@jay171717
Copy link

BRO ITS MY BUG, WHY REPOST

@jay171717
Copy link

MY POST HAS DETAILS ABOUT IT PLS CHECK, ITS THE PREVIOUS POST #4406

@jay171717
Copy link

ok sorry my bad, i am new to github so i don't know anything about it, idk how to fix it as I cant prevent "healing dead players"

@PierreSchwang
Copy link
Member Author

It was fixed by me and will be part of the next release. That's why your issue is closed - as it's fixed.

@jay171717
Copy link

ok thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/plot flag set heal <value>
4 participants