Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostPlotClearEvent added #4268

Merged
merged 12 commits into from
Jan 21, 2024
Merged

PostPlotClearEvent added #4268

merged 12 commits into from
Jan 21, 2024

Conversation

David-M-GitHub
Copy link
Contributor

@David-M-GitHub David-M-GitHub commented Dec 14, 2023 •
edited by NotMyFault
Loading

Overview

PostPlotClearEvent added

Fixes #4288

@David-M-GitHub David-M-GitHub requested a review from a team as a code owner December 14, 2023 21:48
@dordsor21
Copy link
Member

I think it could be worth making this a player event, as the clearing player could be a moderator/admin, not just the plot owner for example

PierreSchwang
PierreSchwang requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And don't delete the checklist. It's there for a reason (e.g. describing the usage of the since annotation)

Core/src/main/java/com/plotsquared/core/events/post/PostPlotClearEvent.java Show resolved Hide resolved
Core/src/main/java/com/plotsquared/core/events/post/PostPlotClearEvent.java Outdated Show resolved Hide resolved
Core/src/main/java/com/plotsquared/core/util/EventDispatcher.java Outdated Show resolved Hide resolved
Core/src/main/java/com/plotsquared/core/util/EventDispatcher.java Outdated Show resolved Hide resolved
Core/src/main/java/com/plotsquared/core/util/EventDispatcher.java Outdated Show resolved Hide resolved
@dordsor21
Copy link
Member

dordsor21 commented Dec 16, 2023 •
edited
Loading

I would still like this to be extend PlotPlayerEvent as the player executing the clear would be useful to know and please ensure that the imports are cleaned up in the files to follow the project code style and spotless requirements

@PierreSchwang PierreSchwang mentioned this pull request Jan 11, 2024
Closed
2 tasks
@NotMyFault NotMyFault requested a review from dordsor21 January 12, 2024 08:35
@PierreSchwang PierreSchwang linked an issue Jan 20, 2024 that may be closed by this pull request
PlotClearEvent Result is always null #4288
Closed
2 tasks
@NotMyFault NotMyFault merged commit 76ea9e0 into IntellectualSites:main Jan 21, 2024
9 checks passed
@NotMyFault NotMyFault added the Enhancement New feature or request label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@PierreSchwang PierreSchwang PierreSchwang approved these changes

@dordsor21 dordsor21 Awaiting requested review from dordsor21

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlotClearEvent Result is always null
4 participants
@David-M-GitHub @dordsor21 @NotMyFault @PierreSchwang