Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow admin done permission to override requiring plot complexity calculation #4267

Merged

Conversation

MrJoshuaT
Copy link
Contributor

Overview

Let admins always be able to set plots as done

Description

The permission plots.admin.command.done already exists but is only used to check if you have plot perms, it's very useful to allow admins with the permissions to not require doing plot calculations.

Also removed PlotSquared.platform().expireManager() == null condition on same line because it can never return null.

Submitter Checklist

Preview Give feedback

@MrJoshuaT MrJoshuaT requested a review from a team as a code owner December 12, 2023 20:30
@github-actions github-actions bot added the Feature This PR proposes a new feature label Dec 12, 2023
@MrJoshuaT MrJoshuaT force-pushed the AllowAdminsToMarkAsDone branch from c17fb17 to 203644f Compare December 14, 2023 23:52
@NotMyFault NotMyFault requested a review from dordsor21 December 16, 2023 16:14
@dordsor21 dordsor21 requested a review from a team December 16, 2023 18:20
@dordsor21 dordsor21 merged commit c8b4a2f into IntellectualSites:main Dec 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR proposes a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants