Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make d4xx unloadable #110

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Make d4xx unloadable #110

merged 1 commit into from
Jul 4, 2022

Conversation

jnzw
Copy link
Contributor

@jnzw jnzw commented May 30, 2022 •
edited
Loading

  • Change sd->owner from THIS_MODULE to NULL so that we can unload the driver
  • Remove unnecessary try_module_get/module_put
  • Clean up metadata video nodes during remove
  • Make embedded.video dynamically allocated
  • Init embedded only if set in device tree
  • Disable metadata for IR in the DTS

@jnzw
Copy link
Contributor Author

jnzw commented Jun 2, 2022 •
edited
Loading

Only patch 62 is relevant, the other two patches are from #107.

@jnzw
Copy link
Contributor Author

jnzw commented Jun 6, 2022 •
edited
Loading

This PR depends on the metadata related changes in #107, namely adding metadata for IR, so we should consider merge that first.

@jnzw jnzw marked this pull request as ready for review June 9, 2022 03:02
@jnzw
Copy link
Contributor Author

jnzw commented Jun 10, 2022

I've cleaned up this PR to include only necessary changes, and cherry-picked Xin's modification to enable dynamic creation of embedded metadata nodes based on DTS config.

@d1ntel @xzhangxa Could you please review?
Thanks.

@xzhangxa
Copy link
Collaborator

It seems this branch no longer depends on on #107 and some code changes in that PR are moved here. Because that one won't be merged soon and this one will be merged earlier? Doing so you'll have to fix conflicts again for that PR later.

@jnzw
Copy link
Contributor Author

jnzw commented Jun 13, 2022

@xzhangxa Yes, exactly. In the last meeting Evgeni said #107 can't be be merged soon, so we should merge this PR first and then fix that PR later. The code changes moved here are for creating metadata nodes based on dts configuration.

@jnzw
Make d4xx unloadable
3827b9b 
Signed-off-by: Junze Wu <junze.wu@intel.com>
@ev-mp ev-mp merged commit 254f5c4 into IntelRealSense:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp left review comments

@xzhangxa xzhangxa xzhangxa approved these changes

@dmipx dmipx dmipx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jnzw @xzhangxa @ev-mp @dmipx