Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lower FPS in D405, D455 #2612

Merged

Conversation

SamerKhshiboun
Copy link
Contributor

@SamerKhshiboun SamerKhshiboun commented Feb 1, 2023

Tracked by [LRS-527], [DSO-18534]

  • Added missing params in rs_launch.py:
    • depth_module.enable_auto_exposure
    • depth_module.exposure (for manual exposure)
    • rgb_camera.enable_auto_exposure: true

Description:
D405, D455 models, have default manual depth exposure value of 33000
If enable_auto_exposure is off, the depth FPS of 30 will be reduced to 15, since the manual exposure is high, the camera will try to get the first frame within this 33000 [μs], but since it very close to the 30FPS high limit (33333.33333μs) and due to other FW syncs inside the camera, we are missing this 30 FPS Goal, then we lose a cycle of frames, so the FPS is cut by half.

So, if user want to turn off depth_module.enable_auto_exposure or use HDR features (which disable auto_exposure), he must set the depth_module.exposure to a value that is lower than ~32200 in order to bypass the problem I described above.

Updated the launch file to set depth_module.exposure to be 8500, to be aligned with D435 default manual exposure. User can override this in the launch file or in the ros2 run/launch cmd line

@SamerKhshiboun SamerKhshiboun force-pushed the add_hdr_launch_file branch 2 times, most recently from bcd3d9d to 646f8bd Compare February 1, 2023 22:41
@SamerKhshiboun SamerKhshiboun force-pushed the add_hdr_launch_file branch 5 times, most recently from 065c825 to f116867 Compare March 19, 2023 17:54
@SamerKhshiboun SamerKhshiboun changed the title add new launch file for hdr merge Fix lower FPS because HDR disables auto exposure Mar 19, 2023
@SamerKhshiboun SamerKhshiboun force-pushed the add_hdr_launch_file branch 2 times, most recently from ece10fd to b2d3e61 Compare March 19, 2023 19:22
@SamerKhshiboun SamerKhshiboun requested a review from Nir-Az March 22, 2023 07:32
@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review March 22, 2023 07:32
@SamerKhshiboun SamerKhshiboun marked this pull request as draft March 22, 2023 14:02
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great investigation work!

@Nir-Az Nir-Az merged commit 86ab0c8 into IntelRealSense:ros2-development Mar 22, 2023
@lifeisgood-ai
Copy link

Thanks @SamerKhshiboun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants