Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by [LRS-527], [DSO-18534]
Description:
D405, D455 models, have default manual depth exposure value of 33000
If enable_auto_exposure is off, the depth FPS of 30 will be reduced to 15, since the manual exposure is high, the camera will try to get the first frame within this 33000 [μs], but since it very close to the 30FPS high limit (33333.33333μs) and due to other FW syncs inside the camera, we are missing this 30 FPS Goal, then we lose a cycle of frames, so the FPS is cut by half.
So, if user want to turn off depth_module.enable_auto_exposure or use HDR features (which disable auto_exposure), he must set the depth_module.exposure to a value that is lower than ~32200 in order to bypass the problem I described above.
Updated the launch file to set depth_module.exposure to be 8500, to be aligned with D435 default manual exposure. User can override this in the launch file or in the ros2 run/launch cmd line