-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ucal fixes #9882
Ucal fixes #9882
Conversation
Change-Id: If097075eaca121384c1402fb5472463b6802f6d5
… enhancements. LRS-323 Change-Id: I779cf59b0a7866a91eb1339cd67a22b821da1815
Change-Id: I21926ff7abf4b5c84a115b9b3d36083a17001361
Change-Id: I93a771edfe5f7b98e022104916ac45bdeea67e6f
Change-Id: Ie63198250ade72738baa9ba34f2865b5fc72e643
Change-Id: I99d3bb2b09b72888d28ba35b0fc6f0a462337c46
Change-Id: Ieb960bb265a02af3a354c33c9234cc52ef212c78
Change-Id: I64a437f46c91095352fe71f827e6b4f7018626f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment - relevant for several files
@@ -1012,6 +1012,8 @@ namespace rs2 | |||
float step = 50.f / limit; // frames gathering is 50% of the process, the rest is the internal data extraction and algo processing | |||
|
|||
rs2::frame_queue queue(limit*2,true); | |||
rs2::frame_queue queue2(limit * 2, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you think of some other name than queue, queue2 and queu3, so that it would explain the aim of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are marked opaque on purpose to allow incremental development
Approved |
Ucal amendments
Tracked on: DSO-17774, DSO-17775, LRS-323