debug & T265 improvements in rspy.devices #8700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMirbach
reviewed
Mar 30, 2021
| @@ -48,7 +48,16 @@ def __init__( self, sn, dev ): | |||
| self._product_line = None | |||
| if dev.supports( rs.camera_info.product_line ): | |||
| self._product_line = dev.get_info( rs.camera_info.product_line ) | |||
| self._port = acroname and _get_port_by_dev( dev ) | |||
| self._physical_port = dev.supports( rs.camera_info.physical_port ) and dev.get_info( rs.camera_info.physical_port ) or None | |||
There was a problem hiding this comment.
Maybe add parentheses so it's clear that the 'and' is before the 'or'?
There was a problem hiding this comment.
But and is always of greater precedence than or :)
MMirbach
reviewed
Mar 30, 2021
unit-tests/py/rspy/devices.py
Outdated
| split_location = [int(x) for x in usb_location.split('.') if int(x) > 0] | ||
| # only the last two digits are necessary | ||
| return acroname.get_port_from_usb( split_location[-2], split_location[-1] ) | ||
| import re |
There was a problem hiding this comment.
This seems to appear in several locations. Maybe it's better to just import it at the beggining?
There was a problem hiding this comment.
Okay, moved to beginning
MMirbach
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.