Set depth invalidation enabled by CMake flag #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Apr 23, 2020
src/l500/CMakeLists.txt
Outdated
| @@ -21,3 +21,7 @@ target_sources(${LRS_TARGET} | |||
| "${CMAKE_CURRENT_LIST_DIR}/l500-serializable.h" | |||
| "${CMAKE_CURRENT_LIST_DIR}/l500-options.h" | |||
| ) | |||
|
|
|||
| if (ENABLE_DEPTH_INVALIDATION) | |||
| add_definitions(-DDEPTH_INVALIDATION_ENABLED) | |||
There was a problem hiding this comment.
I suggest you keep the define name the same as the CMake variable to make it more intuitive to search
maloel
reviewed
Apr 23, 2020
src/l500/l500-depth.h
Outdated
| @@ -111,7 +117,8 @@ namespace librealsense | |||
| << "Unsupported depth invalidation enabled " << val << " is out of range."); | |||
| }); | |||
|
|
|||
| register_option(static_cast<rs2_option>(RS2_OPTION_DEPTH_INVALIDATION_ENABLE), _depth_invalidation_option); | |||
| // The depth invalidation enable option is depricated for now. | |||
maloel
reviewed
Apr 23, 2020
CMake/lrs_options.cmake
Outdated
| option(ANDROID_USB_HOST_UVC "Build UVC backend for Android - deprecated, use FORCE_RSUSB_BACKEND instead" OFF) | ||
| option(ENABLE_DEPTH_INVALIDATION "Turn on the depth frame validator" ON) |
There was a problem hiding this comment.
Might want to mention it's for L500 only... maybe make it ENABLE_L500_DEPTH_INVALIDATION?
Also, it's not exactly clear what "depth invalidation" is -- maybe mention "to automatically catch corrupted frames and restart the sensor"?
…nvalidation_enabled_v2 Merge changes from origin
dorodnic
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.