Add RS2_OPTION_FREEFALL_DETECTION_ENABLED #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On by default
aangerma
reviewed
Feb 4, 2020
ev-mp
reviewed
Feb 4, 2020
| @@ -61,7 +61,8 @@ | |||
| ENABLE_POSE_JUMPING(57), | |||
| ENABLE_DYNAMIC_CALIBRATION(58), | |||
| DEPTH_OFFSET(59), | |||
| LED_POWER(60); | |||
| LED_POWER(60), | |||
| FREEFALL_ENABLED(63); | |||
There was a problem hiding this comment.
Pls fill in the missing 61-62 indexes
src/l500/l500-private.cpp
Outdated
| { | ||
| bool_option::set( value ); | ||
|
|
||
| command cmd{ FALL_DETECT_ENABLE, value != 0.f }; |
There was a problem hiding this comment.
Float comparison to zero can be tricky - in other places we put
(fabs(a-b)< std::numeric_limits<float>::epsilon()) template
There was a problem hiding this comment.
I changed to is_true(), but that compares to the range min. You think we should change the comparison there?
ev-mp
reviewed
Feb 4, 2020
maloel
changed the title
ev-mp
reviewed
Feb 5, 2020
| virtual void set( float value ) override; | ||
| virtual const char * get_description() const override | ||
| { | ||
| return "When enabled (default), the sensor will turn off if a free-fall is detected"; |
There was a problem hiding this comment.
Is there a specific threshold established - e.g. 0.8G ?
ev-mp
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an L500 camera experiences free-fall (is dropped) a safety mechanism is triggered and turns off the depth sensor to protect moving parts inside the camera.
This is on by default, and can now be disabled with this option.
Tracked on: RS5-6461