Remove "not supported for rendering" error #4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the stream display window instead
ev-mp
reviewed
Sep 22, 2019
common/rendering.h
Outdated
| // glTexImage2D(GL_TEXTURE_2D, 0, GL_LUMINANCE, width, height, 0, GL_LUMINANCE, GL_UNSIGNED_BYTE, data); | ||
| // break; | ||
| //} | ||
| // default: |
There was a problem hiding this comment.
Leaving the switch case without default must be avoided.
There should be some way to report this error without compromising the handling loop.
Is it possible to refactor the report string into the default case ?
common/viewer.cpp
Outdated
| ImGui::SetCursorScreenPos({ min_x + max_x / 2.f - 200, min_y + max_y / 2.f - 20 }); | ||
|
|
||
| ImGui::PushStyleColor(ImGuiCol_Text, sensor_header_light_blue); | ||
| std::string text = to_string() << textual_icons::exclamation_triangle << " The requested format is not supported for rendering "; |
There was a problem hiding this comment.
Please add format name to the message
common/viewer.cpp
Outdated
| @@ -1281,6 +1298,11 @@ namespace rs2 | |||
|
|
|||
| stream_mv.show_stream_header(font1, stream_rect, *this); | |||
| stream_mv.show_stream_footer(font1, stream_rect, mouse, *this); | |||
|
|
|||
| if (stream_mv.profile.format() == RS2_FORMAT_RAW10 || stream_mv.profile.format() == RS2_FORMAT_RAW16) | |||
There was a problem hiding this comment.
Can this be invoked ifrom within ::upload(... call ?
AnnaRomanov
force-pushed
the
unsopported_rendering_error
branch
from
bef35e1 to
6bb2320
Compare
dorodnic
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When streaming a format that is not supported for rendering, instead of throwing error notifications, show message that rendering is not supported in the stream view.